Skip to content

Parse the raw sglang config into a dedicated pydantic model - #1993

Merged
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-53
Sep 4, 2026
Merged

Parse the raw sglang config into a dedicated pydantic model#1993
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-53

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Jul 30, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 2 times, most recently from ee919af to b2e19f2 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 8f1ccb9 to 7524f41 Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from b2e19f2 to 45421c5 Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 7524f41 to 9213e4d Compare August 4, 2026 06:54
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 45421c5 to f494144 Compare August 4, 2026 07:26
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 9213e4d to 7298a9a Compare August 4, 2026 07:26
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from f494144 to 61da3b6 Compare August 4, 2026 07:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 7298a9a to a9b31b1 Compare August 4, 2026 07:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 61da3b6 to 68347c4 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from a9b31b1 to 7f97fe5 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 68347c4 to ae95b83 Compare August 6, 2026 07:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 5d36d65 to f9382c4 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 2 times, most recently from b450d6a to cbd480c Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch 2 times, most recently from 4300270 to ac323a2 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from cbd480c to 0992754 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from ac323a2 to a5f9b6c Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 0992754 to 51299ba Compare August 10, 2026 16:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 2 times, most recently from a8c749e to 4ece9b4 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch 2 times, most recently from 51d5ceb to db1910e Compare August 14, 2026 04:45
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 4ece9b4 to 92838b3 Compare August 14, 2026 04:46
guapisolo
guapisolo approved these changes Aug 26, 2026
View reviewed changes

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in stack context: #1994 (a0e8a39) replaces #1993's frozen eval-config mutation with model_copy transformations, and the fix remains intact through #2649, including safe merge checkpoint #2176.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 92838b3 to 9b7da78 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from db1910e to 8db3f76 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 9b7da78 to 44c52b1 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 8db3f76 to 40d4644 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 44c52b1 to 2a733d1 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 40d4644 to 1b2dfba Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 2 times, most recently from f200a1c to cb1e1fa Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 5e189a4 to 4493a9f Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from cb1e1fa to 20f936e Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 4493a9f to d734cb6 Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 2 times, most recently from cd48f6b to bd502d9 Compare September 3, 2026 07:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 45c19fc to 94868c4 Compare September 3, 2026 10:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch 3 times, most recently from af2195f to ebdeb77 Compare September 4, 2026 00:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 98661f7 to 85424c8 Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from ebdeb77 to 80c4bd2 Compare September 4, 2026 03:28
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-54 branch from 85424c8 to ef14c46 Compare September 4, 2026 05:42
Base automatically changed from tom/refactor-miles/op13-54 to main September 4, 2026 05:42
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-53 branch from 80c4bd2 to 8eaa595 Compare September 4, 2026 05:42
@fzyzcjy
fzyzcjy merged commit 220f128 into main Sep 4, 2026
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guapisolo guapisolo guapisolo approved these changes
@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu yushengsu-thu is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fzyzcjy @guapisolo